Apply changes from ST-0017. #1359
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
stmontgomery
reviewed
Oct 8, 2025
Sources/Testing/Attachments/Images/Attachment+AttachableAsImage.swift
Outdated
Show resolved
Hide resolved
|
See also swiftlang/swift#84792 |
grynspan
force-pushed
the
jgrynspan/promote-windows-image-attachments-to-api
branch
from
e5f0002 to
5c4bab7
Compare
Base automatically changed from
jgrynspan/promote-windows-image-attachments-to-api
to
main
October 9, 2025 19:13
grynspan
added
the
cross-import-overlays
grynspan
force-pushed
the
jgrynspan/image-attachment-adjustments
branch
from
3c7784a to
fd84e29
Compare
This PR applies the changes from [ST-NNNN](swiftlang/swift-evolution#2985). It merges `AttachableAsCGImage` and `AttachableAsIWICBitmapSource` into a single `AttachableAsImage` protocol and it adjusts the interfaces of `AttachableImageFormat` and `Attachment where AttachableValue: AttachableAsImage`.
grynspan
force-pushed
the
jgrynspan/image-attachment-adjustments
branch
from
4deabab to
5ea43ab
Compare
younata
approved these changes
Oct 22, 2025
Sources/Overlays/_Testing_WinSDK/Attachments/AttachableAsIWICBitmapSource.swift
Show resolved
Hide resolved
Sources/Overlays/_Testing_CoreGraphics/Attachments/AttachableAsCGImage.swift
Show resolved
Hide resolved
Sources/Overlays/_Testing_AppKit/Attachments/NSImage+AttachableAsImage.swift
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the changes from ST-0017. It merges
AttachableAsCGImageandAttachableAsIWICBitmapSourceinto a singleAttachableAsImageprotocol and it adjusts the interfaces ofAttachableImageFormatandAttachment where AttachableValue: AttachableAsImage.Checklist: